Web: Migrate metrics_view to explore resources
#5724
Merged
+3,611
−2,652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egde/explore-metrics-ui-split
AdityaHegde
changed the base branch from
main
to
begelundmuller/explore-resources-breaking
AdityaHegde
force-pushed
the
adityahegde/explore-metrics-ui-split
branch
from
9b21984
to
27499d2
Compare
…egde/explore-metrics-ui-split
…egde/explore-metrics-ui-split
AdityaHegde
force-pushed
the
adityahegde/explore-metrics-ui-split
branch
from
c15acf2
to
5d80175
Compare
AdityaHegde
force-pushed
the
adityahegde/explore-metrics-ui-split
branch
from
03dc315
to
c83bc01
Compare
ericpgreen2
changed the title
metrics_view to explore resources
AdityaHegde
force-pushed
the
adityahegde/explore-metrics-ui-split
branch
from
6f78f95
to
c80db41
Compare
…egde/explore-metrics-ui-split
AdityaHegde
merged commit de4dcb8
into
begelundmuller/explore-resources-breaking
6 checks passed
AdityaHegde
added a commit
that referenced
this pull request
Oct 1, 2024
* Migrate `metrics_view` to `explore` resources (breaking) * Self review * Roll back docs changes * Web: Migrate `metrics_view` to `explore` resources (#5724) * Refactor StateManagers to use explore * Replace useMetricsView - Pass 1 * Use explore in state defaults * Add basic explore editor * Replace metricViewName with exploreName where applicable in rill dev * Update bookmarks * Fix navigation on cloud * Fix alerts and reports * Migrate Public URLs * Redirect old Explore URLs to `.../explore/[name]` * Migrate embeds * Fix syncDimensions * Fix eslint * Fix `svelte-check` * `metricViewName` -> `metricsViewName` * `useMetricsView` -> `useMetricsViewValidSpec` * `useDashboard` -> `useMetricsView` * `useDashboardStore` -> `useExploreStore` * `useMetaMeasure` -> `useMetricsViewSpecMeasure` * Add two `+page.ts` files to `tsc` whitelist * Fix "Function called outside component initialization" * Add Metrics View icon * `MetricsExplorerIcon` -> `ExploreIcon` * Fix unit tests - Pass 1 * Fix unit tests - Pass 2 * Fix unit tests - Pass 3 * Fix tsc * Revise new files from "Add" button * Better organization of `features/explores`, `features/metrics-views` * Refactor `new-files.ts` to account for files bootstrapped from another resource * Add "Create Explore dashboard" button to Metrics Workspace * Nits * "Generate dashboard" -> "Generate metrics" * "DashboardMenuItems" -> "MetricsViewMenuItems" * `useValidExplore` -> `useExploreValidSpec` * `useValidDashboards` -> `useValidExplores` * Add YAML syntax highlighting to `ExploreEditor` * Partially fix Preview mode's Explore CTAs * Explore E2E pass 1 - Fix model and explore editing * Explore E2E pass 2 - Fix metrics editing in tests * Explore E2E pass 3 - Fix metrics editor experience * Fix eslint * Explore E2E pass 3 - Fix incorrect test migration * Avoid using useMetricsView * Fix resource->resource navigation buttons * Use the right icons * Update e2e tests * Fix missing icon * Fix navigation through top nav bar * Restore migration for billing table --------- Co-authored-by: Eric P Green <[email protected]> --------- Co-authored-by: Aditya Hegde <[email protected]> Co-authored-by: Eric P Green <[email protected]>
k-anshul
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Migrate `metrics_view` to `explore` resources (breaking) * Self review * Roll back docs changes * Web: Migrate `metrics_view` to `explore` resources (#5724) * Refactor StateManagers to use explore * Replace useMetricsView - Pass 1 * Use explore in state defaults * Add basic explore editor * Replace metricViewName with exploreName where applicable in rill dev * Update bookmarks * Fix navigation on cloud * Fix alerts and reports * Migrate Public URLs * Redirect old Explore URLs to `.../explore/[name]` * Migrate embeds * Fix syncDimensions * Fix eslint * Fix `svelte-check` * `metricViewName` -> `metricsViewName` * `useMetricsView` -> `useMetricsViewValidSpec` * `useDashboard` -> `useMetricsView` * `useDashboardStore` -> `useExploreStore` * `useMetaMeasure` -> `useMetricsViewSpecMeasure` * Add two `+page.ts` files to `tsc` whitelist * Fix "Function called outside component initialization" * Add Metrics View icon * `MetricsExplorerIcon` -> `ExploreIcon` * Fix unit tests - Pass 1 * Fix unit tests - Pass 2 * Fix unit tests - Pass 3 * Fix tsc * Revise new files from "Add" button * Better organization of `features/explores`, `features/metrics-views` * Refactor `new-files.ts` to account for files bootstrapped from another resource * Add "Create Explore dashboard" button to Metrics Workspace * Nits * "Generate dashboard" -> "Generate metrics" * "DashboardMenuItems" -> "MetricsViewMenuItems" * `useValidExplore` -> `useExploreValidSpec` * `useValidDashboards` -> `useValidExplores` * Add YAML syntax highlighting to `ExploreEditor` * Partially fix Preview mode's Explore CTAs * Explore E2E pass 1 - Fix model and explore editing * Explore E2E pass 2 - Fix metrics editing in tests * Explore E2E pass 3 - Fix metrics editor experience * Fix eslint * Explore E2E pass 3 - Fix incorrect test migration * Avoid using useMetricsView * Fix resource->resource navigation buttons * Use the right icons * Update e2e tests * Fix missing icon * Fix navigation through top nav bar * Restore migration for billing table --------- Co-authored-by: Eric P Green <[email protected]> --------- Co-authored-by: Aditya Hegde <[email protected]> Co-authored-by: Eric P Green <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #5722
Adds a basic yaml editing experience for explore.